You can't rely on people spotting the significance of such changes

Tests would have caught it = https://github.com/rhysd/actionlint injection check

	▲	thejosh an hour ago \| parent [-]
		also been a huge fan of zizmor (https://github.com/zizmorcore/zizmor) lately, basically: "am I going to footgun myself?"

▲

dv_dt an hour ago | parent | prev | next [-]

I have been talking to people who want to autoreview and approve "minor" AI prs. For security especially, I think if the models weren't enough to prevent the issues, they aren't enough to judge what is minor.

▲

fn-mote 2 hours ago | parent | prev [-]

Absolutely.

Nothing in the PR jumps out as a red flag. Unless you know how the internals work, I suppose.

▲

larsonian 40 minutes ago | parent | next [-]

Are you kidding? It's a very obvious case of quote injection. Not some subtle race condition or anything.

	▲	joombaga 11 minutes ago \| parent [-]
		I think it's obvious too. I'd call out any case of `${{ }}` interpolation in a `run` block, and it's something I watch for in PRs. I also know other people don't watch for this, as I've corrected it about a hundred times. Over the last 10 years my average colleague understands less and less about injection or to watch for it at layer boundaries.

▲

chrisjj an hour ago | parent | prev [-]

> Nothing in the PR jumps out as a red flag.

Made by AI?