Remix.run Logo
fn-mote 2 hours ago

^^

Absolutely.

Nothing in the PR jumps out as a red flag. Unless you know how the internals work, I suppose.

larsonian 38 minutes ago | parent | next [-]

Are you kidding? It's a very obvious case of quote injection. Not some subtle race condition or anything.

joombaga 9 minutes ago | parent [-]

I think it's obvious too. I'd call out any case of `${{ }}` interpolation in a `run` block, and it's something I watch for in PRs. I also know other people don't watch for this, as I've corrected it about a hundred times. Over the last 10 years my average colleague understands less and less about injection or to watch for it at layer boundaries.

chrisjj an hour ago | parent | prev [-]

> Nothing in the PR jumps out as a red flag.

Made by AI?