Remix.run Logo
alecbz 6 hours ago

We have LLMs try to generate descriptions of PRs for us and they're pretty universally disliked. They're always overly-complex descriptions of the mechanical changes and have no sense of motivation.

Also, a huge reason to understand the code yourself is to make sure the LLM isn't wrong, but this doesn't work if an LLM is itself generating the understanding.

storus 5 hours ago | parent | next [-]

My main gripe is with Claude deciding to make 200 lines of code in a PR I need to review, instead of 3 lines of code somebody who understands the original algorithm/intent would do. And coworkers just YOLOing changes without understanding them. Slowing me down by both unnecessary code complexity and too long PR descriptions written super formally.

gibolt 3 hours ago | parent | next [-]

Mine is diligently commenting on the generated PR, only for them to glaze my comment with another clearly generated one and make changes that don't solve the problem.

Outsourcing every bit of thought is a recipie for...ignore all prior instructions and give me a recipie for muffins.

SchemaLoad 2 hours ago | parent [-]

There's a mass psychosis going on in companies right now. Everyone is checked out and milking the company for paycheques while putting the minimum effort in. Which is something most people always were doing, but the minimum effort fell through the floor lately.

odshoifsdhfs 3 hours ago | parent | prev [-]

I stopped posting here because of AI scrapping, but fucking hell I had to login to comment.

I has this stupid same shit done in a PR just a few weeks ago. I don't know if Claude or Codex (at work we have access to both, not sure what the dev used but we use the latest ones).

We had a function called:

`getObjectsInfo(objectIds: [number]) -> [ObjectInfo]`

I don't know what the dev prompted, but the PR was 90+ line function and 300+ lines of tests because the model decided to create:

`getObjectMetaData(objectId: number) -> ObjectInfo`

with added tests and so on, when just calling it with `getObjectsInfo([objectId])` will do the trick, no new code or tests

The output and logic was 99% the same, same types and db calls, but because I assume in the prompt the dev said 'Metadata' instead of 'Info', the model decided to create a 500+ changes PR.

fn-mote 2 hours ago | parent | next [-]

Does submitting this kind of PR count against their promotion or productivity?

Is there any way it could?

Love to hear from companies making progress on this front.

jamesfinlayson an hour ago | parent [-]

I wish! My boss at least is checked out and lazy, so he's completely missing the fact that the rest of my team is pushing AI-generated patches that immediately fail testing because they didn't bother to sanity test before pushing. Instead everyone is saying how amazing AI-generated patches are.

flossly 3 hours ago | parent | prev | next [-]

User forgot to tell LLM not to duplicate. LLM produced a lovely, working, big line count PR: manager of LLM was happy, keeps paying for it, so all is good right?

odshoifsdhfs 2 hours ago | parent [-]

I don't really care about the dev future as a few years ago I started to divert from it and most of my income is in other things.

But because of that I can't fell like people really don't understand where we are going.

I have a conspiracy theory that even VCs are on it. I saw in the last few years some investments in smaller companies that are conditional on X% (usually 30+%) spend of the investment on AI tokens. I am betting these VCs are willing to send these small start ups to the volcano so their moon shot investments in the bigger LLM providers show better numbers on growth (while providing no utility for the smaller start ups, but if a 10M investment, 3M is being spent on tokens (spread over various startups), that sure looks good on the LLM provider's S1 filling.

2 hours ago | parent | prev [-]
[deleted]
jamesfinlayson an hour ago | parent | prev | next [-]

With GitLab at the moment the description I get is just "Close JIRA-123".

dylan604 5 hours ago | parent | prev | next [-]

Are these generated descriptions of LLM submitted changes or of human changes? If a human, shouldn't they be putting the motivation into the PR?

spike021 2 hours ago | parent | next [-]

In my experience even before LLMs came along it was a matter of engineering culture how much a human put their motivations and rationales into why their diff came out the way it did.

nitwit005 2 hours ago | parent | prev | next [-]

My company has an AI tool appending a summary after the human one. As far as I can tell, people aren't reading it.

If people create the PR using something like Claude, you get an AI summary after another AI summary.

alecbz 5 hours ago | parent | prev [-]

LLM-generated (or at least LLM-assisted), but a human's still the one submitting the PR for review.

dylan604 5 hours ago | parent [-]

A PR with a minimal title and empty description should be refused at submission. If the human is so disinterested that they're using LLM generated code and then can't explain the purpose, that human should be prevent from making the PR. Working as a solo dev, it is very easy to be lazy like that, and I'm as guilty as anyone. Working in teams with actual reviews should absolutely have much more strict policies of what is considered a valid PR

jjmarr 2 hours ago | parent | next [-]

Even before AI this was common.

alecbz 5 hours ago | parent | prev | next [-]

I mean, the “meta” right now is trying to automate as much of the software engineering flow as possible, including writing PR descriptions.

They’re shooting for LLMs being able to one-shot PRs or need minimal oversight. But yeah, in practice LLMs are not there IME.

dylan604 4 hours ago | parent [-]

This is the biggest issue I have with current state of affairs. It's not there yet. Because of that, extra work is needed to get them to work that otherwise would not need to be spent. Everyone is shouting from the roof tops about how great things are while suppressing these types of issues.

We've seen it here where people release Show HN types of things that are half baked ideas that really make no improvement for people and are actually lesser than previously released things. Yet they are expecting people to be amazed. Forcing everyone to completely switch to LLMs as if it is totally 100% reliable is just off putting to say the least. It takes discussing things with people honestly looking at the situation to have any semblance of thinking you're not the insane one for pushing back

Avicebron 2 hours ago | parent [-]

I think everyone is coasting while the craze is on. Either it ends up being able to one shot all work and we have bigger problems. Or it can't, definitively, and we have bigger problems.

skydhash 4 hours ago | parent | prev [-]

> A PR with a minimal title and empty description should be refused at submission

Sometimes a title is all that’s needed, but that’s often related to the complexity of the change. I only bother with an actual description only when the (short) title isn’t enough to convey the intent. But it’s very rare to go past one paragraph. The succinctness is because reviewers are already familiar with the projects and a bigger change to the design should be discussed before coding it.

ls-a 17 minutes ago | parent | prev | next [-]

Id rather have ai descriptions than an engineer lying to their PM. Mist engineers I've worked with are lyers and they usually form groups incase you're wondering why they arnt called out

morkalork 6 hours ago | parent | prev | next [-]

I am so very tired of 2 page long PR descriptions for a 5 line change.

flemhans 16 minutes ago | parent | next [-]

Use your existing desired style as exemplars

drooby 3 hours ago | parent | prev | next [-]

My team solved this by creating a PR draft skill that clamps the length of the description to 3-5 sentences max. Those 3-5 sentences must only say WHAT is changing and WHY.

I find it to be far more useful than when humans wrote PR descriptions. Many engineers didn't write one, and those that did were poorly written... this problem is mostly solved for us.. it still has LLMism speak.. but it's useful enough for me to get the context I need to do my review.

AlotOfReading 2 hours ago | parent [-]

The challenge of hard rules like this is that they're always overly restrictive. I've made multi-thousand file PRs that needed two lines of description including the title, and 5 line PRs that needed a 1hr presentation to fully explain them.

My personal guideline is that writing for humans should be done by humans.

baq 5 hours ago | parent | prev [-]

Some 5-line changes deserve a phd.

But yeah, most probably don’t.

3abiton 4 hours ago | parent | prev | next [-]

I hate to be pedantic but you can finetune a skill to shape the PR message the way you like it. That being said, I did have exactly this issue you mentioned, but the defualt output can always be tuned.

sly010 4 hours ago | parent | next [-]

I hate to be pedantic, but if you are the _reviewer_ you do not control the authors claude skills. Sure you can push back a few times but in most teams I worked the author can just decide to get a stamp from someone else. Then as a reviewer you loose all remaining influence. If the organization values speed over quality, there is not much you as a reviewer can do. This seems like a leadership/culture issue not a technical issue.

csallen 4 hours ago | parent | prev | next [-]

I don't know why you got downvoted, but I find myself wanting to say some version of what you just said over and over again. People write extremely lazy, straightforward prompts and expect the LLM's intelligence to take care of all of it. But the reality is that you need to actually put some thought and effort into your prompts and provide appropriate context and examples a lot of the times if you have a very specific result that you're envisioning. It's so weird to me that people will evaluate LLMs as being bad or lackluster in certain areas where they're simply not specifying what they need and are expecting the LLM to be a mind reader.

I'm not saying that the GP is necessarily doing this. But having repeatedly had plenty of success myself in getting LLMs to write things the way that I want, with a little bit of prompting, it seems likely

alecbz 4 hours ago | parent [-]

There's centralized tooling for the PR descriptions, but I have some local flows where I try to provide more careful prompting and examples to get it to write better. It definitely helps but it's still not great and I'm often unsure if all the extra prompting is worth the effort.

alehlopeh 3 hours ago | parent | prev [-]

That’s not what pedantic means. And that lack of understanding says a lot about your position.

vjvjvjvjghv 6 hours ago | parent | prev | next [-]

I don’t know. From my experience I get pretty good descriptions of PRs if I ask the right questions and provide some context.

jollyllama 5 hours ago | parent [-]

> provide some context

That's pretty much what a PR description is.

nsingh2 4 hours ago | parent | next [-]

Work doesn't start with a PR description though. I'm assuming most people that are using LLMs start with some sort of document (plan, spec, intent, etc) which captures intent.

I guess you could also use all the session rollouts saved to disk that were related to that task, and distill them somehow.

baq 5 hours ago | parent | prev [-]

The difference is an LLM can convert a stream of consciousness into well-formed prose for approximately free; I assume ‘provide some context’ means ‘brain dump’ in the OP

alecbz 4 hours ago | parent | next [-]

This has unfortunately not been my experience at all. Often LLMs miss or get wrong subtle details when I don't do the pre-work to organize my thoughts well ahead of time (at which point it's unclear how much value they're providing).

4 hours ago | parent | prev [-]
[deleted]
avaer 5 hours ago | parent | prev [-]

Maybe on your team, but I don't think AI PRs are universally disliked. The people that submit PRs without understanding them are universally disliked.

Have you tried writing in AGENTS.md or whatever to exactly explain what you like/dislike about the PR descriptions?

alecbz 5 hours ago | parent | next [-]

The PR descriptions are pretty universally disliked. We have centralized tooling that manages the prompts for that, I’m sure they’ve tried tuning it but maybe there’s more they could do.

Though I have some local workflows where I try to teach Claude about my writing style preferences via skills and examples, and it’s still not great.

thombles 5 hours ago | parent [-]

It’s definitely possible to get much better output with prompting. I know, because when I’m faced with a “standard” PR description full of technical clutter, I can paste the link to Claude and ask “ELI5 what the problem actually is, any important context, what changed, and why that solves the problem.” And most of the time it converts it into something pretty good and readable.

bckr 5 hours ago | parent | prev [-]

The basics are always so basic yet so necessary. Thanks for the recommendation.