▲ | serf 2 days ago | ||||||||||||||||||||||||||||||||||||||||||||||||||||
>How can my feedback improve you as a software developer if you don't understand your own code? Just say that you don't want my code, better yet just silently reject it. I don't want a moral referendum about how my code shall be the mana by which all future reviewers and practitioners of the art shall sup and become enlightened. Group education isn't my job as someone submitting a PR to fix some trivial shit. Sometimes it doesn't need to be smart, sometimes it doesn't need to be a learning experience by which we all grow. Throw out the garbage, keep the good stuff, and appreciate the attention to the project. Be happy that someone wants to help. | |||||||||||||||||||||||||||||||||||||||||||||||||||||
▲ | collinmcnulty 2 days ago | parent | next [-] | ||||||||||||||||||||||||||||||||||||||||||||||||||||
If you don’t care about the reason for rejection, you don’t have to read it. Many people will ask for a reason and take even more of a maintainer’s time, so writing once and linking helps. | |||||||||||||||||||||||||||||||||||||||||||||||||||||
▲ | ath3nd 2 days ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||||||||||||||||||||
> Throw out the garbage, keep the good stuff, and appreciate the attention to the project The garbage in the case of an AI generated PR, is all of it. I will happily reject all of your slop and every future contribution from you if you can't follow the project's contribution guidelines. If you don't like that, that's what forking is for. > Just say that you don't want my code, better yet just silently reject it. Not only I don't want it but I have some ideas what you can do with it and wher this code can go. Also, the code is not yours. I can generate the same amount of garbage as you myself using the same tools, and it will also not be mine, yet I stop myself from doing it, because more garbage is the last thing this world needs. > Be happy that someone wants to help How full you must be of yourself to consider pointing an LLM towards a repo as helping. Must have been very difficult to point Claude towards a repo and trash code goes brrr, something that every person with a pulse can do. And I shudder at the the entitlement to think that OSS maintainers have to thank you for your godly prompt and 0 amount of effort. | |||||||||||||||||||||||||||||||||||||||||||||||||||||
| |||||||||||||||||||||||||||||||||||||||||||||||||||||
▲ | zulban 2 days ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||||||||||||||||||||
> Group education isn't my job It doesn't sound like I'd like your dev culture. This is also explicitly part of the work objectives of me and my team. > Sometimes it doesn't need to be smart I prefer code that is dirt simple and stupid actually. | |||||||||||||||||||||||||||||||||||||||||||||||||||||
▲ | AdieuToLogic 2 days ago | parent | prev [-] | ||||||||||||||||||||||||||||||||||||||||||||||||||||
>>How can my feedback improve you as a software developer if you don't understand your own code? > Just say that you don't want my code, better yet just silently reject it. These decision points are orthogonal, in that the author identifies a social contract wherein a contributor must have an understanding of the change-set they submit in order for it to be a viable candidate. Determining if the submitted change-set is applicable/appropriate/correct and how to provide feedback to the contributor is a subsequent activity. |