Remix.run Logo
▲ fusslo 7 hours ago

We've stopped reviewing code for code's sake. We review code to keep the codebase clean and consistent.

Before agentic development, the cost was large for changes at the review stage. Often the person writing the code didn't have the right context or experience to make the best choice. So reviewing would often blow up a pull request. Which sucked. Eventually every engineer would have AI generate a PR. People would review, blow it up, and the engineer would copy/paste the feedback into AI to generate another PR.

But now, we use reviews to enforce design decisions and get feedback from the other people who couldn't be involved in the initial design (for example if a new feature interacts with a module owned by another team).

The actual nuts-and-bolts of how the code is written is mostly unimportant. It was a large mentality shift for the company

We spend LOTS of time on the design, verification, testing. The verification and testing is built first. Agents take the input of the problem, design document, and current codebase to generate code. It iterates by running the verification tools. Then it runs the testing tools.

The better we make the tools for AI, the better the product code is. We've automated gathering power readings, timing reports, wifi/ble sniffing, smoke tests, feature tests, corner cases, robots for pressing buttons, static analysis tools, unit tests, customer styled system tests... tools to emulate cell phones, servers, etc...

▲ 6 hours ago | parent | next [-]
[deleted]
▲insane_dreamer 6 hours ago | parent | prev | next [-]

> We spend LOTS of time on the design, verification, testing.

sure, this is short-term because you still have people around who wrote (most of) the code and understand it

once you no longer have a good understanding of the codebase, you also don't know what to test and validate

AI is great at writing tons of tests; whether they're the _right_ tests is another question

▲RE-call 6 hours ago | parent | next [-]

[flagged]

▲ 6 hours ago | parent | prev [-]
[deleted]
▲bluefirebrand 7 hours ago | parent | prev [-]

> The actual nuts-and-bolts of how the code is written is mostly unimportant

I am struggling to come to terms with this personally. I was someone who really tried hard to make sure the nuts and bolts was good quality. Kept on top of language features, made sure not to use deprecated APIs that could expose security problems, etc

It wasn't just "to make the code more maintainable" or anything, those choices mattered, or felt like they did

Now it feels like everyone is saying "those choices don't matter, and never did"

Have I just been wasting my time and focusing on the wrong stuff for my whole career?

▲dust-jacket 6 hours ago | parent | next [-]

No they absolute did matter. They just matter a lot less now.

I'm going to ignore the using an actually broken API, and instead think about using a sub-optimal one.

Before, you tried hard to get it right first time, because it was a pain to change if it wasn't.

Now, that change is much, much easier. A task like "rip out this deprecated package and replace with a new one" used to be a LOT of effort but, if we're honest, not an awful lot of skill. Now its quick and easy.

Making the right product choices, or architectural decisions remains just as important, because they're still an absolute nightmare to change later, but the nuts and bolts much less so.

▲fusslo 6 hours ago | parent [-]

right. Making the right choices is really hard

One thing I am still seeing is we STILL can't admit when we're wrong. We refuse to believe that we cannot think of everything before the code gets into production.

Really it's some core teams who do not have a 'sustaining' budget. They call themselves Services R&D.

For example they made a messaging stack with encryption, serialization, addressing, routing, etc. But it has a huge flaw in that there is a maximum packet size. The design is such that an app cannot implement chunking on top of the messaging. So there is no way to transmit data greater than the packet size or do any kind of data streaming. THere are 3 products now who are mandated to use this messaging stack but can't fit into the packets

It seems like a culture of 'deliver and move on' rather than 'deliver, support, improve'. Not sure how to fix this problem

▲ostensible 6 hours ago | parent | prev [-]

> I am struggling to come to terms with this personally. I was someone who really tried hard to make sure the nuts and bolts was good quality.

Think of assembler vs compilers for higher abstraction level languages. When you write in C or Python you trust the compiler to do the right thing and don't routinely review generated assembly let alone machine code.

It's the same here. You write your program in natural language and have the compiler (ai) make it happen. This is what it will converge eventually to.