| ▲ | bengold14 5 hours ago | ||||||||||||||||
I think most people at this point just don't review code. Which is a shame, because: 1. It was good for collaboration. Sharing how you are changing the codebase pushes everyone to row in the same direction, and provides a sense of team ownership. 2. It was good as a push for engineers to take pride in their work. Knowing someone is watching gives you subconsciously an extra reason to not cut corners. And when you spend effort not cutting corners you expect that in your teammates, which is a (potentially) virtuous circle. 3. It was good for catching mistakes. When code was expensive this was important. Everyone thinks of code review as primarily relevant for 3, and since code is no longer expensive they think it is unimportant and you can skip it. But 3 isn't dead, its importance has just shifted from code to architecture. It is still an expensive mistake to screw up architecture and have other engineers build upon that flaw. Re-architecting with live users, data and/or hardware is not as simple as fixing a code bug, and it deserves attention to catch mistakes. Collaboration & pride are also still important. This is the reason that instead of stopping review, we need to change what abstraction we review. Code is no longer the right tool for understanding applications in most cases. (disclosure I work in this space and run https://www.archme.io which is working to solve the above) | |||||||||||||||||
| ▲ | cgarvis 5 hours ago | parent | next [-] | ||||||||||||||||
I agree with your premise but I would argue that your still operating under the model that we are all still working with all the "developers" that we needed before because we need someone to type out the code. I like your ArchitechMe approach because it operates at what is left. The Software Engineers still need to "work on the system, not in the system". Before those folks were in the code, but with so much being written now we need better tools like you ArchitechMe to make sure the system is operating like we want it to. | |||||||||||||||||
| |||||||||||||||||
| ▲ | matltc 4 hours ago | parent | prev | next [-] | ||||||||||||||||
What's up with all the trackers? Sounds interesting but closed immediately due to their presence | |||||||||||||||||
| |||||||||||||||||
| ▲ | esafak 4 hours ago | parent | prev | next [-] | ||||||||||||||||
I don't agree with your premise, that code is cheap and unimportant. It is cheap, but bugs aren't unless you have a monopoly, and vibe coded software as you describe is invariably buggy. | |||||||||||||||||
| |||||||||||||||||
| ▲ | imtringued 3 hours ago | parent | prev [-] | ||||||||||||||||
I'll be honest about your project. Asking an agent to create the model is the wrong way around. It may surprise you but code review is actually something you need to automate with deterministic software. For some reason people don't seem to understand what a developer's job is. Automating code review sounded asinine two years ago because the cost of managing the automated process exceeded the cost of manual reviews. Aka it was pointless busy work. But now that we have potentially adversarial agents, it is kind of essential. | |||||||||||||||||