| ▲ | jacobgorm 4 hours ago |
| The problem is that when nobody writes code or feels ownership over it anymore, nobody will be qualified to or really interested in doing the code reviews. The way forward could involve dropping code reviews altogether. You could argue that the useful pingpong between coder and reviewers has been replaced by the similar pingpong between the prompter and the agent. |
|
| ▲ | spoaceman7777 30 minutes ago | parent | next [-] |
| > "nobody will be qualified to or really interested in doing the code reviews" It is a job you know... doing what is necessary to keep yourself qualified is an implicit requirement, and "being interested" is irrelevant. It's work. |
| |
| ▲ | torben-friis 4 minutes ago | parent [-] | | I agree with you in principle, but I'm also quite sure that (some) programmer's love for the craft is what keeps the lights on in many companies. It's the usual stereotype, engineers fighting to keep tech debt at bay while management pushes for speed. The trade has a low bottom, a high ceiling and not a lot of reward for the latter. |
|
|
| ▲ | michaelchisari 2 hours ago | parent | prev | next [-] |
| The compressed timelines which result when leadership sees how quickly code can be produced becomes pressure on the reviewer to not be a blocker. |
| |
| ▲ | biggoodwolf an hour ago | parent | next [-] | | Reviewers are the most burnt out right now | |
| ▲ | taneq 2 hours ago | parent | prev [-] | | Seems like a way for the ones churning out the code to push responsibility onto reviewers. |
|
|
| ▲ | prmoustache 4 hours ago | parent | prev | next [-] |
| In my company, people found out that if they use an agent that commits and do the pull/merge request, they can approve it themselves and bypass a second set of eyes. Since they are the one doing the prompting, they quickly got lazy of actually reviewing the output from the LLM which means that nobody is reviewing anything. It hasn't happened yet but I guess that is how you end up with major outages. |
| |
| ▲ | taurath 3 hours ago | parent | next [-] | | This is everywhere to my knowledge, and engineers are burning out left and right with stress because of how little anyone understands the code, and how much of a mountain of nobody knowing anything they have to handle. We are turning our critical infrastructure mechanisms into stochastic grey goo. I find the engineers currently thriving are the ones who never gave a fuck about anything but their own advancement and are happy to drop weeks of work on others and take the credit. | | |
| ▲ | guhidalg 2 hours ago | parent [-] | | Understanding is overrated, application code (user-space) is anyway just a way to make money. If you're making more money over time, you're doing it right. We're not writing kernel code or safety critical code, we can let AI do the heavy lifting of putting characters into a file. | | |
| ▲ | dweinus 34 minutes ago | parent | next [-] | | This comment is crystaline perfection. I could not more clearly state the soul sucking ethos of AI hype that makes me want to walk into the sea. | |
| ▲ | tcoff91 2 hours ago | parent | prev | next [-] | | There are plenty of apps that while not safety critical, are financially critical to people's lives. When you're working on an app that processes billions of dollars in payments per month you can't just yolo it. | |
| ▲ | taurath an hour ago | parent | prev [-] | | It’s funny that anyone still thinks that these practices aren’t being applied to safety critical code in order to make money. | | |
|
| |
| ▲ | fingerlocks 10 minutes ago | parent | prev [-] | | This is why we need to resurrect the neglected git-blame and go back to the days of git-before-GitHub. Way back in the old timey days of 2009-ish, just before the Dawn of the Pull Request, code reviews were seldom. Maybe you’d all get a conference room and talk about architecting some new thing or whatever, but none of this endless nit-picking bullshit that came later. And there were no branch protections, anyone could crap all over the main branch (nee: master) anytime they wanted. Boy, those were some wild times, let me tell ya! Truth be told, it was the firm hand of the git blame-and-shame that kept our code civil and orderly. Binding contract written in blood was “the name on the blame owns the change”. If you pushed it, you owned it. For life. Of course, mental health wasn’t so great back in those days, but I would take that over having my PR blocked all day because Chad, who’s only gift is somehow finding a new hill to die on every day, thinks zero is a “magic number” there’s no way he’s going to budge on this issue. |
|
|
| ▲ | jwilliams 2 hours ago | parent | prev | next [-] |
| [flagged] |
|
| ▲ | taurath 3 hours ago | parent | prev | next [-] |
| > The way forward could involve dropping code reviews altogether. Yes, if we stop doing quality controls, we don't have the problem of being hung up on quality controls. You do of course have SOC-2 compliance which is a legally auditable attestation, so if you claim you do code review but don't you're committing fraud unless you drop that. |
|
| ▲ | bambu 3 hours ago | parent | prev | next [-] |
| That would be great, IF there were valuable ping-pong between the prompter and the agent. For skilled engineers the game between themselves and the agent is enough. But most people are submitting senseless slop grenades for review. Claude always comes up with more things to add to the code that are pure bloat and become inbred bombs over several iterations, and some people can't distinguish what suggestions to reject and go along with everything Claude suggests to the detriment of the program #garrytangate |
|
| ▲ | triMichael an hour ago | parent | prev [-] |
| I'm having good luck with the approach of building a thorough requirements specs that are a few pages long, are quite reviewable, and are human written/AI reviewed to prevent it from becoming slop. I call it layered spec driven development, where the one layer is AI read only, and the other layer is the slop layer that AI can play in. The problem is that it requires slowing down just a smidge, which to management these days is more unacceptable than no one having any clue how anything works. |