> Something is a small-change if it meets all of these criteria it is less than 1,000 lines of code

Only my personal view but even 1000 LoC is not a "small change".

andreimackenzie 4 hours ago | parent | next [-]

This struck me too, but I think it is intentionally a high limit to prevent problems like relatively low impact/high LoC tests from tipping a small change into a large one. That would encourage gamification like skipping useful scenarios to keep a change "small".

The other criteria are more important.

▲

skydhash 4 hours ago | parent | prev | next [-]

Yep a small changes is one computer screen of diff (36 to 48 lines) excluding generated changes (lock files, formatted files,…)

	▲	koolba 43 minutes ago \| parent \| next [-]
		It can be even more lines as long as the hunks are continuous. Once you lose the context of change and have to “zoom out” to see where it fits in, the review time grows significantly.
	▲	jaggederest 3 hours ago \| parent \| prev [-]
		A thousand characters, perhaps, and we can gently exclude whitespace in languages insensitive to it.

▲

jibalt 3 hours ago | parent | prev [-]

AND, not OR.

	▲	lukeify 2 hours ago \| parent [-]
		How the rule is composed with other rules is irrelevant to my statement that a small change is not "1000 lines".