Remix.run Logo
▲ fg137 38 minutes ago

You will be surprised by how many professional software engineers don't read their code or care these days.

I have seen a bubble sort function in a PR from an engineer with 10 years of experience. Meanwhile sort from standard library is easily available with one single line.

The bar has become as low as "it works" without considering what's in the code or whether the entire feature should even exist at all.

P.S. that same engineer sent out a PR of 200-file feature. The PR is so large that it freezes the latest MacBook Pro if you try to read it. Nobody reviewed it and he merged it himself. Nobody uses that feature, and nobody in the teams wants to maintain it. Now we are considering scrapping it.

▲callc 7 minutes ago | parent [-]

It’s so easy to generate a pile of crap now that it “just works” as you say.

Quality, maintainability, simplicity, understandability, flexibility etc all still matter at $DAY_JOB, where you’ve got paying customers. We’ve got a responsibility to write good software that adds to people’s lives.

I’d recommend to try to raise the bar. Commit messages written by humans, no PRs above a certain size, any PR needs an introduction / explanation by author first for the reviewers.