new | show | ask | jobs Github

LunicLynx 9 hours ago

Unfortunately this often represents the only feedback given by the people in those „higher“ positions.

„The indent is wrong here“

„Comments should end with a period“

Because this kind of feedback is and was always easy.

▲

parpfish 9 hours ago | parent [-]

If you get feedback like that, it’s time for your team to get automated linting/formatting

▲

refactor_master 7 hours ago | parent [-]

Call for a style guide meeting every time you see feedback like this, and write down what everybody agrees on. You’ll never have to do it again after 3-4 of those. Problem solved.

Still not solved? Guess it was really about the commas and not the value delivered anyway, so do whatever you feel like.

▲

parpfish 4 hours ago | parent [-]

That meeting sounds like it would be the most bikeshed-y thing imaginable.

What you actually need to do is have a manager lead assert that it’s happening in a top down way and just run the formatter with the defaults. Let people argue case-by-case on what to change after that.

	▲	eichin 2 hours ago \| parent [-]
		The point is that you get the (inevitable) bikeshedding done once, everyone feels "involved", and then you have a style guide that is both a style guide and a "crystallized argument" - so when someone wants to change something, they know that dozens of people already signed off on it and do they really want to push against that. (So covering new things is still lower friction...)