Remix.run Logo
cyberax 8 hours ago

The last time I checked the source code, it was filled with horrible unsafe C++. They also re-implement everything whether it is needed or not.

adamrt 4 hours ago | parent | next [-]

> It was filled with horrible unsafe C++

Are you saying their code was horrible and unsafe, or just that its a byproduct of using C++. They've been rewriting parts in rust: https://github.com/LadybirdBrowser/ladybird/blob/8f0a1b19114....

> They also re-implement everything whether it is needed or not.

No they don't. SerenityOS did, and that was the goal of the project. But Ladybird has plenty of third party libraries.

cyberax 3 hours ago | parent [-]

> Are you saying their code was horrible and unsafe, or just that its a byproduct of using C++.

Yes.

It's both terrible because it's C++, and it's terrible because they're not following the modern C++ safe coding practices.

> They've been rewriting parts in rust: https://github.com/LadybirdBrowser/ladybird/blob/8f0a1b19114....

And it's not going to amount to anything major. Rewriting in Rust properly requires architecting things from the beginning.

> No they don't.

For a long time, their policy had been "no third-party code". Eventually it became untenable, so they started using third-party libraries. But they still ended up reinventing the wheel at least several times.

dieortin 6 hours ago | parent | prev [-]

Aren’t Chrome and Firefox also filled with “horrible unsafe C++”?

cyberax 6 hours ago | parent [-]

Yup. But they had thousands of engineers working on them for a decade.

unloader6118 4 hours ago | parent [-]

Doesnt that makes it even less consistent ?

cyberax 4 hours ago | parent [-]

Why? C++ is horrible, but when you have thousands of developers, you can make it work.