| ▲ | mort96 13 hours ago | |||||||||||||
I actually can't read this. > The statement-list walk without the per-list pending-fiber flush "Per-list pending-fiber flush?" Surely there's a clearer way to express this? Was it helpful necessary to describe "the statement-list walk" as a noun instead of talking about "walking the statement list"? > A pure move: processStmtNodesInternalWithoutFlushingPendingFibers() becomes a delegating wrapper and the loop body is byte-identical Did this need to be prefixed by "A pure move"? Why does the bytes of the text content of the loop body matter? I found this too: https://github.com/phpstan/phpstan-src/commit/a9260cb3584854... > Parked fibers are idle workers, not pending work - skipping their no-op fuel starves nothing. "No-op fuel"? Really? | ||||||||||||||
| ▲ | bakugo 12 hours ago | parent [-] | |||||||||||||
> I actually can't read this. I don't think anyone can. At this point, I'm almost starting to believe it's an intentional move to discourage reviewing AI-generated commits by making them extremely unpleasant to read, in favor of just pushing straight to master without question. | ||||||||||||||
| ||||||||||||||