| ▲ | trq_ a day ago | |||||||||||||
I did make the decision, and shipped the PR. | ||||||||||||||
| ▲ | cadamsdotcom a day ago | parent | next [-] | |||||||||||||
Unfortunately this is a sign that the systems by which PRs are shipped need serious inspection. For example in incident management, the industry settled on blameless postmortems. Blame is pointed at the systems which allowed incidents to occur, never the human(s) who triggered the incident. "Just don't make that mistake again" simply doesn't work. Humans make mistakes! There are too many stakeholders in a product this large, even if every one of them wishes it were not so. The systems by which this PR shipped need serious inspection. | ||||||||||||||
| ▲ | grim_io a day ago | parent | prev | next [-] | |||||||||||||
I don't really care, in a most positive way towards you. I don't hold you accountable even if you twirled your mustache like a villain. You are not responsible for Claude Code. Why did the leadership set up such a weak, error-prone process? Again, not asking you directly, because it doesn't matter to me what you say, respectfully. | ||||||||||||||
| ▲ | Jcampuzano2 a day ago | parent | prev | next [-] | |||||||||||||
Okay I stand corrected then. Seems strange for a company of your size to have one person push changes that should have easily caught this edge case then. Seems like a change even a small handful of people could have reasonably thought up this side effect of. | ||||||||||||||
| ||||||||||||||
| ▲ | cube00 a day ago | parent | prev | next [-] | |||||||||||||
There has to be a second PR approver. There's no way a company as large this can allow an individual the ability to push to production without a secondary person involved. When there's at least two people involved you can then start to look at more systematic factors that go beyond any single human mistake. When both the submitter and approver miss that there's no changelog entry for a PR does that mean a checklist is needed? Should the changelog be automated with the commit message which can be improved for external consumption? I'd find it very hard to believe that this high profile change just happened to be the only change missing from the changelog. Bugs are always going to happen but housekeeping like writing something to a changelog when a commit is merged can be quality assured. | ||||||||||||||
| ||||||||||||||
| ▲ | petesergeant a day ago | parent | prev [-] | |||||||||||||
Habibi, I don't think anyone is really blaming you personally. We are piling on to the fact that this piece of critical infrastructure many of us depend on day in day out is being built in such a way that a single developer can wake up one morning, ship a change they thought might be nice, and then walk it back the next day. | ||||||||||||||