My definition of colonialism generally involves people being subjugated and being treated as less and involuntarily part of an empire. People in Gibraltar are British citizens with full rights by definition.

Land borders that one doesn't like doesn't equate to colonialism. It's just a land border that you don't like. The people of Gibraltar voted almost 100% to be British on more than one occasion. Trying to make them not British is the definition of colonialism