| ▲ | midtake 17 hours ago | |
> We have senior engineers review the actual functionality and none of them have read any more than a few lines of code. A senior engineer should be able to efficiently read thousands of lines of code per day. Maybe this is what you meant by "a few"? | ||
| ▲ | unknownfuture 16 hours ago | parent | next [-] | |
Alas no: https://smartbear.com/lean/code-review/best-practices-for-pe... > A SmartBear study of a Cisco Systems programming team revealed that developers should review no more than 200 to 400 lines of code (LOC) at a time. The brain can only effectively process so much information at a time; beyond 400 LOC, the ability to find defects diminishes. ... > SmartBear research shows a significant drop in defect density at rates faster than 500 LOC per hour. Code reviews in reasonable quantity, at a slower pace for a limited amount of time results in the most effective code review. | ||
| ▲ | christophilus 17 hours ago | parent | prev | next [-] | |
I doubt the thousands of lines per day claim unless the lines are trivial. It’s quite fatiguing to read hundreds. | ||
| ▲ | thraway3837 17 hours ago | parent | prev [-] | |
No, I really meant that we don't even read the code anymore. In another comment I wrote: we just CMD+Q VS Code and it's not even in the recents/pin to dock, since what's the point? We can see the diffs in the PR and quickly gloss over it and query/prompt/ask clarifications. | ||