The primary purpose of code review is to maintain existing hierarchy by preventing junior SWEs from getting promoted by committing code that is smarter than what the senior architect can understand.

▲

SketchySeaBeast 5 hours ago | parent [-]

If the code is so smart that it's not easily understandable, it's not easily fixable. My transition from junior to senior was accompanied by the realization that simpler is nearly always better.

▲

sjducb 4 hours ago | parent | next [-]

Good programmers write code that’s so simple and obvious it looks like anyone could have written it.

Bad programmers make the simplest things really complicated.

▲

cat_plus_plus 5 hours ago | parent | prev [-]

Write me simple AI inference code that has high performance in big batches.

▲

SketchySeaBeast 4 hours ago | parent | next [-]

I don't know enough to speak about that particular domain, but if the junior is writing something the senior can't understand, that's always going to be a problem. That code becomes the team's responsibility, and that code needs to be able to be maintained by the entire team, not only by the junior with something to prove.

Who is getting called at 2 AM when something breaks? Not the junior.

▲

cat_plus_plus an hour ago | parent [-]

Hehe you think L9s do oncall? Senior not understanding is a problem all right. It's not necessarily junior's problem.

	▲	SketchySeaBeast 3 minutes ago \| parent [-]
		I feel like you keep missing the point and are more interested in gotcha's.

▲

4 hours ago | parent | prev | next [-]

[deleted]

▲

AlotOfReading 4 hours ago | parent | prev [-]

Does tinygrad not count for some reason?