| ▲ | gnunicorn 7 hours ago | ||||||||||||||||||||||
Interestingly, despite it being much more detailed and a lot more process and procedure than what I currently do - which is more akin to the version 0 described, but in parallel - we come up at the same final problem: reviews and quality assurance. I sign off the code I merged, part of company policy but also just to be sure it is actually decent. But reviewing has become the real draining bottleneck: even stacked PRs, if that total 5-6k lines is not a 5min job. Even if I brainstormed and set the plan, that's really the part that doesn't scale right now for me in this. But the author is very shy about that: either the changes arent that big in the end or they trust the process enough to review in a more casual manner. Being equally untrusting I can't do that ... | |||||||||||||||||||||||
| ▲ | philbo 5 hours ago | parent | next [-] | ||||||||||||||||||||||
For decades, engineers understood that large code reviews are harder than small ones. Out of both politeness and a desire to receive better code reviews, we learned to break our large changes into smaller chunks. Some engineers took things even further and replaced code reviews with pair programming. But then LLMs showed up and everyone seems to have forgotten those lessons. They can be still be applied now using coding agents, if you're willing to push back against the default setup and change your mode of thinking a little bit. Of course it doesn't help that an entire industry is dedicated to persuading us that maximizing token spend is the only way to get shit done. I appreciate this probably seems like an extremist take, but I wrote some more about it here in case there's anybody out there who identifies with it: | |||||||||||||||||||||||
| |||||||||||||||||||||||
| ▲ | strogonoff 7 hours ago | parent | prev | next [-] | ||||||||||||||||||||||
Proper review should take longer than writing it yourself, because you need to know the correct solution, understand the proposed solution, and evaluate the difference between the two. When designing it yourself, you just need to know the correct solution and write it, and with modern high-level languages and IDEs with autocomplete writing it is hardly a bottleneck. | |||||||||||||||||||||||
| |||||||||||||||||||||||
| ▲ | nisabek 7 hours ago | parent | prev [-] | ||||||||||||||||||||||
If I'm attentive during spec/plan creation I sort of build this "expectation" of what the actual PR will look like, the mental model of it. Then it's somewhat easier to review. But the mental load is brutal tbh, and still not sure if it's "worth it" | |||||||||||||||||||||||