Remix.run Logo
philipnee 2 hours ago

Just want to comment here. I hate reviewer leave a bunch of nits and stamp the PR. This is ambiguous, are these nits asks or just you opinions? What if I dont address all of them. Also folks need to take rejection lightly - your reviewer wants you to address something, thats really it.

lexicality 2 hours ago | parent [-]

Hi, I do this.

> are these nits asks or just you opinions?

If I've approved the PR, then these are changes I'm asking you to do, but not ordering you to do. You are free to say "no" to my request

> What if I dont address all of them

Then you will have decided that you don't agree with my recommendation and that's OK.

I only ever do this with people I trust - I am trusting you to review each of my nitpicks and make an informed decision if they're necessary or not. Generally I'd like you to reply to the ones you don't do with a reason though.