| ▲ | elpocko 8 hours ago |
| > FFmpeg compiled to WebAssembly handles final encode FFmpeg's license is the LGPL 2.1. VidStudio looks like closed source software, I couldn't see any indication that it's free software. You're distributing this software to run in the client's browser. I'm not a lawyer but I think you're in breach of the terms of the LGPL. https://www.ffmpeg.org/legal.html |
|
| ▲ | prhn 7 hours ago | parent | next [-] |
| Closed source is fine, but there are a few other things that are required of LGPL, some of which are - Provide links to the source of the version of ffmpeg you used in your code - User should be able to replace the ffmpeg libs with his own compatible builds if you're using dynamically linked libs. For statically linked libs, you need to provide the tools to re-link against a compatible build. I went through an LGPL review recently so some of this is fresh in my memory, but please correct me if I'm wrong. |
| |
| ▲ | mghackerlady 6 hours ago | parent | next [-] | | I knew about the soft copyleft (the source code requirements) but didn't know there was the requirement to have libs be replaceable. Now I want to know how useful that would be in reverse engineering closed systems (particularly nintendos, since I've always had an interest in the homebrew scene there) | | |
| ▲ | noduerme 6 hours ago | parent [-] | | iirc, the video player application VLC used to come without any mpeg support, and you had to go through a process to download ffmpeg separately ...not sure how easy it made it to replace individual libs, but I'm also not sure the license requires you to make it easy. | | |
| ▲ | maxloh 3 hours ago | parent [-] | | VLC is GPL licensed and open source. Maybe that's enough since you could compile it yourself anyway? |
|
| |
| ▲ | xixixao 6 hours ago | parent | prev | next [-] | | Dynamically and statically linked libs is hilarious in the context of webassembly running in the browser. | | |
| ▲ | circuit10 5 hours ago | parent [-] | | You can have multiple WASM modules communicating with each other (though you would probably need extra interop code?), or statically link them into a single module, the concepts work mostly the same | | |
| ▲ | giancarlostoro 2 hours ago | parent [-] | | With a browser plugin I'm sure you could swap out a WASM module on the fly, if said plugin doesn't exist, maybe it should. Would make debugging in a prod URL simpler if you can just load a page with a testing WASM file. |
|
| |
| ▲ | giancarlostoro 3 hours ago | parent | prev [-] | | I think you're right, also an interesting aside: LGPL software is even trickier on the iOS app store, where its out of your control to "let the user link" the software. I guess in that case the only real way is to somehow give them access to the linkable files or allow them to pull in your copy of an LGPL library, but for them to run it on their device, good luck... I'm slowly leaning towards eventually just adopting MPL which is kind of weaker than LGPL but more friendly for iOS, course I mostly just default to MIT license these days. I prefer to let my users use my software however they want without fear that if they someday overhaul my code and build something that works for them, that they would lose it. |
|
|
| ▲ | kolx 7 hours ago | parent | prev | next [-] |
| Thank you for pointing this out, to be completely honest, I did not consider licensing because the website started as a collection of tools I built to run locally and get into video/audio codecs then I realised it is already a decent collection of tools that other people might want to use too.
But I will be making the needed changes to comply fully tonight.
At least I comply with this:
`Do not misspell FFmpeg (two capitals F and lowercase "mpeg")`
I realised I have some more reading to do regarding GPL vs LGPL because of the wasm project. |
| |
| ▲ | jmaw 6 hours ago | parent | next [-] | | You should look into how other companies and tools that use FFMPEG handle this situation. I wonder if you can keep your application itself closed source, but make an open-source adapter that handles the interaction with FFMPEG. I'm not super familiar with open source licensing, and IANAL, so make sure to do your own research :) As an example, I believe Audacity required me to install ffmpeg manually myself, and add it to my path. This is slightly different since Audacity itself is also open source. But could be helpful to reference. | | |
| ▲ | noduerme 6 hours ago | parent | next [-] | | Yes, Audacity definitely requires that. It can't open or save mp3s unless you separately install ffmpeg. | |
| ▲ | kolx 6 hours ago | parent | prev [-] | | Thank you, I guess I won't be fixing any bugs tonight but at least I will figure out how to comply.
I appreciate the help for real! |
| |
| ▲ | zenmac 3 hours ago | parent | prev | next [-] | | Wonder this guy is doing it? Or is it also not open sourced? https://news.ycombinator.com/item?id=42207002 | | |
| ▲ | pdyc 2 hours ago | parent [-] | | that guy is not including ffmpeg and is not encoding in browser. What he is doing is generating a ffmpeg command that you can run on your cli/scripts etc. PS: i am that guy :-) |
| |
| ▲ | freedomben 7 hours ago | parent | prev [-] | | Any reason not to just open source it? Personally I'd love to hack on it :-) IANAL, but IMHO AGPL would be a good fit here as it complies with LGPL and also ensures nobody besides you (the copyright holder) can stand it up for profit without contributing back). | | |
| ▲ | netdevphoenix 7 hours ago | parent | next [-] | | > Any reason not to just open source it? Mmmm...potential commercialisation? Always find it curious that people expect to get source code for free in ways that they don't do for other work (ask George Martin to release his drafts and notes). | | |
| ▲ | sroussey 5 hours ago | parent | next [-] | | Or the other likely version: prevent commercialization. No source means that someone can’t make a fork, put on a new domain, run ads and charge money for his work. | |
| ▲ | mbesto 7 hours ago | parent | prev | next [-] | | The parent commenter is making that comment because this is precisely the nature of why the GPL license exists. Most of the processing of this application is FFMPEG, so why should someone who has done zero development on that library commercialize it? | | |
| ▲ | afavour 6 hours ago | parent [-] | | Most of the processing of the application is FFMPEG yes, but there's a whole lot of application outside of the processing. Video editors UIs that don't make you want to tear your hair out are a valuable commodity and I think OP has the right to commercialize that if they want to. They just need to use FFMPEG in the right way as they do it. | | |
| ▲ | mbesto 3 hours ago | parent | next [-] | | This application doesn't work without FFMPEG. I'm not arguing that the wrapper isn't valuable, I'm saying there is a significant chunk of it that is required for us to work is an open source library. | |
| ▲ | jpc0 3 hours ago | parent | prev [-] | | From what I understand about this application ffmpeg of only used for export? That is very little of the processing of true, they mentioned the webcodec is used extensively and likely the only real requirement on ffmpeg is muxing into mp4 which to be entirely honest isn't much processing. |
|
| |
| ▲ | mghackerlady 6 hours ago | parent | prev | next [-] | | The problem is you can commercialise free software if you're creative about it. RMS made a decent amount of money working on emacs, redhat and SUSE exist, google has managed to commercialise chromium | | |
| ▲ | freedomben 5 hours ago | parent [-] | | > The problem is you can commercialise free software if you're creative about it. Did you mean to say that it is a problem? From the rest of your comment, and in the context of GP's comment, it sounds like commercializing is NOT a problem. | | |
| ▲ | mghackerlady 5 hours ago | parent [-] | | prev said that they might not be willing to release the source code so they can commercialise it |
|
| |
| ▲ | freedomben 7 hours ago | parent | prev | next [-] | | > Mmmm...potential commercialisation? Hence why I asked the question... And not everybody does everything for commercial reasons, so it would be dumb to assume that and therefore not ask the question. > Always find it curious that people expect to get source code for free in ways that they don't do for other work (ask George Martin to release his drafts and notes). Where in my question did you get that I expect to get source code for free in ways that I don't for other work? But regardless, you do know that open source is a common thing right? People open source things all the time, especially on HN. Also OP already says they don't do any uploading of your videos to the cloud, so this thing already runs local-only. It's not like there is a shortage of video editors around (including ... open source ... video editors) | |
| ▲ | randomtoast 6 hours ago | parent | prev [-] | | [dead] |
| |
| ▲ | kolx 6 hours ago | parent | prev [-] | | I never maintained an open source project and not sure how to even do it properly.
I am also not sure how much effort would I have to put to an open source project. I imagine I would need to collaborate with a pretty much anyone who has an interest in the area. Again not that I mind just not sure how much time I have to spare. Right now this is a really slow process and tbh I have to rely on manual testing at least for the editor. | | |
| ▲ | Mashimo 6 hours ago | parent | next [-] | | Nah, besides sharing the code you don't have to do anything. Most people would want you to upload the code to github, then they can star and clone it with ease. But you don't have to have an issue tracker, and you certainly don't have to read any of the issues or pull request. You can ignore or disable that. I think even just having a up to date .zip with all the code would be technically enough. | |
| ▲ | qingcharles 4 hours ago | parent | prev [-] | | You don't have to collaborate with anyone. Just stick the code up on GitHub and if people file issues or PRs, then you can engage or not as you please. There are plenty of projects that are open source but don't accept any public modifications. You might just find you end up with some folks who genuinely want to help out, though. |
|
|
|
|
| ▲ | CodesInChaos 7 hours ago | parent | prev | next [-] |
| It should be possible to comply with LGPL without publishing the source code of the whole application. Either by running the application and ffmpeg in different isolates (wasm processes), or by offering a way to merge (link) the wasm code of the closed-source application with a user compiled FFmpeg wasm build. Different isolates might even be enough to satisfy GPL, similar to how you can invoke FFmpeg as a command line tool from a closed application. Though that feels like legally shaky ground. |
| |
|
| ▲ | senko 7 hours ago | parent | prev | next [-] |
| LGPL permits that. However, some popular codecs use GPL, which, if enabled, would require to distribute the rest of the code under it as well. |
| |
| ▲ | elpocko 7 hours ago | parent [-] | | LGPL permits you to distribute binaries, but you can't distribute the software as an opaque binary blob with no reasonable way to modify it. What even is the equivalent of a shared library that a user can replace when software runs in the browser? Anyway, OP doesn't do most of the things FFmpeg lists under their "License Compliance Checklist". | | |
| ▲ | senko 6 hours ago | parent | next [-] | | Not disagreeing with you, but cases like these really highlight how (L)GPL can nudge vendors into doing more closed solutions with greater lock-in. For example, we're complaining about a licensing issue for an app that can run locally (in your browser, no uploads needed). The licensing issues can easily be side-stepped by the the developer if they chose instead to do all the media manipulation in the backend. In the end, for the user this means they have to upload & trust a random service with their data, potentially can't get raw data out, and other negative side-effects of lock in. | |
| ▲ | trinix912 7 hours ago | parent | prev [-] | | > Anyway, OP doesn't do most of the things FFmpeg lists under their "License Compliance Checklist". Legitimately asking, which points and how are they expected to handle it for this type of app (assuming they want to keep it closed source)? As far as I understand it they just need to credit the libraries? | | |
| ▲ | elpocko 7 hours ago | parent | next [-] | | The important thing is there has to be a clear separation between the proprietary parts and the LGPL parts of the app, and they have to provide a way to replace the LGPL parts. I have no idea how this is usually handled in the case of browser-based apps. | |
| ▲ | actionfromafar 6 hours ago | parent | prev [-] | | User must be able to replace the LGPL library with their own version of the library. |
|
|
|
|
| ▲ | sreekanth850 6 hours ago | parent | prev | next [-] |
| LGPL allow you to use the library in closed source. |
| |
| ▲ | whateveracct 5 hours ago | parent [-] | | Yes but you must distribute in a way where it's trivial to link in another version of the library. So a single wasm blob is a violation. |
|
|
| ▲ | 7 hours ago | parent | prev [-] |
| [deleted] |
