I honestly know I could “optimize” my phone replacement schedule based on resale values of phones etc, but for the last ~15ish years I just replace my iPhone when the battery starts shitting itself (3-5 years each in my experience)