Remix.run Logo
js2 8 hours ago

> stacked diff workflow pioneered by Phabricator

Ahem, pioneered by gerrit. But actually, I'm almost certain even that wasn't original art. I think gerrit just brought it to git.

https://www.gerritcodereview.com/about.html

sunshowers 8 hours ago | parent | next [-]

To my knowledge, stacked diffs were first done in the Linux kernel as stacks of patches sent over email. From there they spread to Google and Facebook. (Source: I worked on Facebook's source control team from 2012-2018 and did a lot of work to enable stacked diffs there.)

js2 8 hours ago | parent | next [-]

Right, I was thinking from a web-based UI. The "pull request" term is from git (AFAIK), but git itself was built to accommodate the earlier concept of mailing patches around. (Source: I've been using version control since RCS/SCCS days and contributed here and there to git in its infancy. Also an early user/contributor to Gerrit.)

hokumguru 4 hours ago | parent | prev | next [-]

Congrats and thank you. You helped build one of the best devex experiences I've ever had the pleasure of working with :)

p-e-w 5 hours ago | parent | prev [-]

At some point, a derivative idea becomes so different from the original one that it’s a novel idea in essence. Just like SMS is ultimately a derivative of cuneiform tablets, and yet it isn’t in any meaningful sense.

sunshowers 5 hours ago | parent | next [-]

I don't think mailing stacks of patches is that different? As someone who built this stuff it was pretty obvious to me that web-based patch stack management was a relatively small evolution over mailing lists. Tools like patchwork bridged the gap initially, and we were quite familiar with them.

monster_truck 5 hours ago | parent | prev [-]

Imagine gettting a cuneiform tablet by courier telling you that you have unpaid parking tickets in a state you've never driven in

pabs3 an hour ago | parent | prev [-]

Gerrit was forked from Rietveld. Not sure if Rietveld or Gerrit are better though.

https://github.com/rietveld-codereview/rietveld https://en.wikipedia.org/wiki/Rietveld_(software) https://codereview.appspot.com/

js2 41 minutes ago | parent [-]

That information is in the about link I included.