Remix.run Logo
Hamuko 9 hours ago

Yeah, I feel like just being able to review a PR commit-by-commit with a nice interface would just suffice.

ezekg 9 hours ago | parent | next [-]

Not really. Without seeing the entire changeset for a PR, you'd have to mentally keep track of what the current state of everything is unless you're a commit minimalist and presquash.

aunderscored 8 hours ago | parent [-]

How does that differ from this where you need to keep track of state and the whole change in the stack?

ezekg 8 hours ago | parent [-]

If we're speaking strictly code review, because you can actually make sense of the changeset for the child PR by not including its unmerged parent's changeset.

benatkin 9 hours ago | parent | prev [-]

For me that would mean avoiding tiny commits, and I wouldn't want to do that