| ▲ | ramijames 6 hours ago |
| This is a team lead/CTO problem. A good leader will be explicit in their expectations that developers write good commit messages. I've certainly had good leaders that expect this. |
|
| ▲ | ryandrake 4 hours ago | parent | next [-] |
| Yes, and a culture problem, too. I guess I've been blessed that I've mostly only worked for "grown up" companies, but I've never encountered a workplace where people didn't write useful commit messages. At least one line description of the work done, but often multiple lines of valuable context. Only the junior devs had to be told to do it, but once they got into the habit, everyone understood why we do it and it was no big deal. If I joined a company where people committed their code with "stuff" or "made some changes" or "asdfhlfo;ejfo;ae," that would be a red flag that I might have joined the wrong company, and I'd start to wonder what else the developers here do carelessly. |
| |
| ▲ | godelski 14 minutes ago | parent | next [-] | | The same goes for code comments though people are much more vocal about their disdain. It's ironic given how frequent AI is used to generate docs. But docs are much better written by the person who wrote the code, the person who has all the context. These things never take much time but people dismiss them because of that. Because each commit and each comment in isolation isn't very valuable but they are very helpful in aggregate. I'm not sure why this bias exists though, since the same is true for lines of code. It's also true about a ton of things. All the little things add up. Just because it's little now doesn't mean it's not important | |
| ▲ | ramijames 2 hours ago | parent | prev | next [-] | | Indeed. If you can't spend two minutes (MAX) writing a sentence or two explaining what the commit is for, then what are we doing as developers? Commits are for future you and your future team. They are a tool. Please, use them. | |
| ▲ | lossyalgo 3 hours ago | parent | prev | next [-] | | Good commit messages would be nice but honestly I would be over the moon if our pull requests would be approved within a week without having to ping one or more people. | |
| ▲ | scottyah 3 hours ago | parent | prev [-] | | Some of my favorite are the perhaps well-meaning but totally misguided log of what files they changed. |
|
|
| ▲ | berkes 3 hours ago | parent | prev | next [-] |
| I once tutored an intern. Who thought he was The Best Programmer On Earth (didn't we all at that age?).
He refused to use revision control, it slowed him down. So we told him to commit at least once every day, with a relevant commit message, or else fail his internship. He worked 21 more days. There were 21 commits: "17:00, time to go home". |
| |
| ▲ | vntok 2 hours ago | parent [-] | | This reads like the intern was left to his own devices and his output not checked at all for three weeks straight. Actual tutoring would have surfaced the issue after 1 or 2 days tops. |
|
|
| ▲ | PUSH_AX 5 hours ago | parent | prev | next [-] |
| I think it's a stretch to measure leadership quality on something so minor, a lot of teams find them pretty useless no matter how good they are. |
| |
| ▲ | munksbeer 4 hours ago | parent | next [-] | | I don't agree. These things actually matter. A developer who isn't told otherwise is just going to do whatever they feel like, so if there is nothing or no-one enforcing the standards, then the failure isn't on the individual developer, it is on the team lead. Someone needs to be setting the standards. In the company I work for, there is a team that has isolated itself to some extent from other teams and works at a furious pace to keep their particular section of the business happy. We're lucky enough that they spun up their own repo to do their work on, so they don't actually impact other teams, but if the quality of the commit messages is anything to go by, I am 100% certain they're going to end up in a huge mess, if they aren't already. The team lead encourages this, and certainly doesn't care about commit messages etc. Developers who care about other developers tend to write better quality code, because they care what other developers think of them. If you care about other developers, you will most likely write decent quality commit messages too. I have seen over many years the types of developers who only care about moving their own code into production as fast as possible and getting to the next thing. There is a very high correlation with a mess at the end, which they inevitably won't have to tidy up because they'll be doing the next thing. These types of developers hate owning stuff in production, so they don't do it, so they don't actually care how maintainable their "clever" code is. I am very certain that a number of people reading this will be those types of developers. | |
| ▲ | xp84 3 hours ago | parent | prev | next [-] | | Useless? So you never use “git annotate” or your IDE to see who wrote a line of code whose purpose puzzles you, and go to the commit message to see what they were trying to accomplish? This is invaluable to me as long as commit messages are clear. As a manager, one of the first things I do is make sure that the PR titles (the PR text becomes the commit messages in squash-merging workflows) at minimum begin with a ticket number. Then we can later read both the intention and the commentary on it. | | |
| ▲ | PUSH_AX 3 hours ago | parent [-] | | > Useless? So you never use “git annotate” or your IDE to see who wrote a line of code whose purpose puzzles you, and go to the commit message to see what they were trying to accomplish? Personally no, the code is the "truth". If I need more I'm going to open a dialog with the author, not spend time trying to interpret a 7 word commit message, "good" or otherwise. | | |
| ▲ | macintux 3 hours ago | parent | next [-] | | The code can only convey what is being done (and then, in some cases, only superficially). It can't convey what decisions were made, what alternatives were discarded, what business motivations may have led to that code. And for old enough code, the author may not be available, or more likely doesn't remember. | | |
| ▲ | PUSH_AX 2 hours ago | parent [-] | | Fine, but none of that is in a normal commit message, lets be real... | | |
| ▲ | mgfist an hour ago | parent [-] | | Which circles back to why it's important for leadership to tackle this | | |
| ▲ | PUSH_AX an hour ago | parent [-] | | Yes, but not in the form of commit messages, the parent comment described things better suited to jira tickets, documentation etc. It feels like we're trying really hard to stretch the utility of commit messages here... | | |
| ▲ | macintux 35 minutes ago | parent [-] | | Mainly I was pushing back on: the code is the "truth" I don't feel that is an accurate statement for any complex system. | | |
| ▲ | PUSH_AX 29 minutes ago | parent [-] | | I don't like complex systems, and I work hard not to create them. | | |
| ▲ | mgfist 16 minutes ago | parent [-] | | Sure but code can't capture everything. Maybe with enough comments I guess, but not code alone. For example, code won't tell you that this feature was timeboxed hence this edgecase was not supported |
|
|
|
|
|
| |
| ▲ | wreath 2 hours ago | parent | prev [-] | | And what of the original author is not there anymore? | | |
|
| |
| ▲ | two_tasty 4 hours ago | parent | prev | next [-] | | I partially disagree. Technical leadership at the micro/mid level should be able to set and enforce standards like "you must have semi-meaningful or meaningful commit messages." If and only if they set those standards, and the team does not follow them, then we can say that either the leadership is lacking, or there is a structural barrier/disincentive to following the rules. Within that framework, I do think using process-smells like this is valid for judging technical leadership. To the point of other commenters however, I wouldn't lay something this micro at the foot of the CTO in all but the smallest of organizations. | |
| ▲ | freedomben 4 hours ago | parent | prev [-] | | It's a stretch to lay at the CTOs feet, but not the team lead or even Head/VP of Engineering IMHO. It's also easy to "enforce" if you're already doing peer review (which you definitely should be, even if not required for compliance). |
|
|
| ▲ | drums8787 3 hours ago | parent | prev | next [-] |
| I particularly love when the “CTO” is also the main offender. |
|
| ▲ | 4 hours ago | parent | prev [-] |
| [deleted] |