Remix.run Logo
recursivecaveat 5 hours ago

Do people really argue about variable names? Most reviews comments I see are fairly trivial, but almost always not very subjective. (Leftover debug log, please add comment here, etc) Maybe it helps that many of our seniors are from a team where we had no auto-formatter or style guide at all for quite a while. I think everyone should experience that a random mix of `){` and `) {` does not really impact you in any way beyond the mild irking of a crooked painting or something. There's a difference between aesthetically bothersome and actually harmful. Not to say that you shouldn't run a formatter, but just for some perspective.

jffhn 3 hours ago | parent | next [-]

>Do people really argue about variable names?

Of course they do. A program's code is mostly a graph of names; they can be cornerstones of its clarity, or sources of confusion and bugs.

The first thing I do when debugging is ensuring proper names, sometimes that's enough to make the bug obvious.

vaylian an hour ago | parent [-]

The greatest barrier to understanding is not lack of knowledge but incorrect knowledge. That's why good names matter. And naming things is hard, which is why it makes sense to comment on variable names in a review.

anal_reactor 4 hours ago | parent | prev [-]

Yes. 80% of comments to my PRs are "change _ to -" or something like that.

blitzar 2 hours ago | parent [-]

PR #467 - Reformat code from tabs to spaces

PR #515 - Reformat code from spaces to tabs