| ▲ | throwaway150 3 hours ago |
| > Every PR needs to be reviewed. Why would you review a PR that you are never going to merge? |
|
| ▲ | allthetime 3 hours ago | parent | next [-] |
| You have to first determine whether or not you might want to merge it... |
|
| ▲ | protocolture 2 hours ago | parent | prev [-] |
| Having not reviewed it, how do you know you are never going to merge? |
| |
| ▲ | throwaway150 2 hours ago | parent [-] | | If a PR claims to solve a problem that I don't need, then I can skip its review because I'll never merge it. I don't think every PR needs reviewing. Some PRs we can ignore just by taking a quick look at what the PR claims to do. This only requires a quick glance, not a PR review. | | |
| ▲ | mwwaters 2 hours ago | parent [-] | | I took this thread as asking whether PRs that are pulled in should be reviewed. |
|
|
