He'll donate to a trust/non-profit he controls that will direct the investment. That allows him to take the tax benefit today and keep the money

Not if he controls the funds. Tax deductions are only afforded to contributions if they are charitable and am actual gift. If the contributor benefits, it is bit deductible, and control of donated funds is a benefit, as is the ability to direct funds to a particular person or persons.