| ▲ | causalscience 9 hours ago | |||||||
Yeah or worse like my boss. We don't have a style guide. But he always wants style changes in every PR, and those style changes are some times contradictory across different PRs. Eventually I've told him "if your comment does not affect performance or business logic, I'm ignoring it". He finally got the message. The fact that he accepted this tells me that deep down he knew his comments were just bike shedding. | ||||||||
| ▲ | zeroCalories 8 hours ago | parent | next [-] | |||||||
You should have a style guide, or adopt one. Having uniform code is incredibly valuable as it greatly reduces the cognitive load of reading it. Same reason that Go's verbose "err != nil" works so well. | ||||||||
| ||||||||
| ▲ | awesome_dude 7 hours ago | parent | prev [-] | |||||||
I've been in teams like this - people who are lower on the chain of power get run in circles as they change to appease one, then change to appease another then change to go back to appease the first again. Then, going through their code, they make excuses about their code not meeting the same standards they demand. As the other responder recommends, a style guide is ideal, you can even create an unofficial one and point to it when conflicting style requests are made | ||||||||