| ▲ | brap 15 hours ago | ||||||||||||||||||||||||||||||||||||||||
Do people actually send PRs with no tests? That is so bizarre to me | |||||||||||||||||||||||||||||||||||||||||
| ▲ | pjdesno 15 hours ago | parent | next [-] | ||||||||||||||||||||||||||||||||||||||||
If your review was based on features shipped, and your bosses let you send PRs with no tests, would you? And before you say "no" - would you still do that if your company used stack ranking, and you were worried about being at the bottom of the stack? Developers may understand that "XYZ is better", but if management provides enough incentives for "not XYZ", they're going to get "not XYZ". | |||||||||||||||||||||||||||||||||||||||||
| |||||||||||||||||||||||||||||||||||||||||
| ▲ | weinzierl 14 hours ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||||||||
> "Do people actually send PRs with no tests?" Rarely Do people send PRs with just enough mostly useless tests, just to tick the DoD boxes. All the time. | |||||||||||||||||||||||||||||||||||||||||
| ▲ | xyzzy123 14 hours ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||||||||
It depends on the application but there are lots of situations where a proper test suite is 10x or more the development work of the feature. I've seen this most commonly with "heavy" integrations. A concrete example would be adding say saml+scim to a product; you can add a library and do a happy path test and call it a day. Maybe add a test against a captive idp in a container. But testing all the supported flows against each supported vendor becomes a major project in and of itself if you want to do it properly. The number of possible edge cases is extreme and automating deployment, updates and configuration of the peer products under test is a huge drag, especially if they are hostile to automation. | |||||||||||||||||||||||||||||||||||||||||
| |||||||||||||||||||||||||||||||||||||||||
| ▲ | brianwawok 15 hours ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||||||||
When I spell text wrong! Or want to add a log. Lots of reasons something is too silly to need a test. | |||||||||||||||||||||||||||||||||||||||||
| ▲ | toephu2 5 hours ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||||||||
Yes, depends on what you're building. Is it just a prototype? no tests needed. Are you trying to move fast and break things? no tests needed. Are tests just not feasible for this piece of code (e.g., all UI, not unit testable), then no tests needed. | |||||||||||||||||||||||||||||||||||||||||
| ▲ | gwbas1c 10 hours ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||||||||
Yes To put things in context, it both depends on organization standards, and what the change actually is. Where I work, there are areas that, if you change, you must update the tests. There are also development helper scripts and internal web sites where "it compiles" is good enough. Likewise, I've done quite a bit of style cleanup PRs where the existing tests are appropriate. | |||||||||||||||||||||||||||||||||||||||||
| ▲ | liampulles 14 hours ago | parent | prev [-] | ||||||||||||||||||||||||||||||||||||||||
I've seen it many times. I think it often arises in business that are not very technical at their core. | |||||||||||||||||||||||||||||||||||||||||