What's the drawbacks of having equalizer as a plugin as opposed to core?

phkahler 6 hours ago | parent | next [-]

First I have to choose one. Second I have to trust a 3rd party. Third, I have to figure out how to use/install it. All this for functionality that should be right there with all the other audio things that are bundled with it.

BTW I hate needing plug-ins or add-ons for other software too for similar reasons - Gnome comes to mind.

	▲	6 hours ago \| parent [-]
		[deleted]

▲

hnuser123456 4 hours ago | parent | prev [-]

If there's a 3-band EQ built in, it should probably be an 8-band instead. 3-band is hardly worth using, 8-band lets you do a decent job of balancing most various audio equipment well enough. Should be hardly any additional code complexity or maint burden for a significant functional upgrade.

	▲	phkahler 3 hours ago \| parent [-]
		>> If there's a 3-band EQ built in, it should probably be an 8-band instead. My thoughts exactly. When I used OBS there was no equalizer. Later I decided to try making one and found they had a new 3-band which was useful for learning how to make audio tools and I was happy to bring my 8-band idea to life. I submitted a PR and one of the devs shepherded me through a few cleanups to make it acceptable. Then they rejected it as somehow non wanted in the project. As an OSS maintainer myself I get it - even though I don't understand the reasons they seemed divided on it since one of them helped with the PR. I try not to speculate on the why, so I have just kept my fork there with the 1 commit to add the 8-band. It's probably way out of date so I should rebase it on latest release. Sounds like there might be some naming convention changes too but I need to find time to look into it.