| ▲ | jphelan 6 hours ago | |||||||||||||
This looks like extremely brittle code to my eyes. Look at https://github.com/wilsonzlin/fastrender/blob/main/crates/fa... What is `FrameState::render_placeholder`? ``` pub fn render_placeholder(&self, frame_id: FrameId) -> Result<FrameBuffer, String> { let (width, height) = self.viewport_css; let len = (width as usize) .checked_mul(height as usize) .and_then(|px| px.checked_mul(4)) .ok_or_else(|| "viewport size overflow".to_string())?;
}
```What is it doing in these diffs? https://github.com/wilsonzlin/fastrender/commit/f4a0974594e3... I'd be really curious to see the amount of work/rework over time, and the token/time cost for each additional actual completed test case. | ||||||||||||||
| ▲ | blibble 6 hours ago | parent | next [-] | |||||||||||||
this is certainly an interesting way to pull out an attribute from a tag: https://github.com/wilsonzlin/fastrender/blob/main/crates/fa... | ||||||||||||||
| ▲ | blamestross 6 hours ago | parent | prev [-] | |||||||||||||
I suppose brittle code is fine if you have cursor to update and fix it. Ideal really, keeps you dependent. | ||||||||||||||
| ||||||||||||||