Fair point. The USA PATRIOT Act shouldn’t have existed in the first place. But one of its most controversial parts (Section 215) did expire in 2020 (it was barely going to make it, though).

But you’re right overall: most of the Act’s powers were repeatedly renewed or re-created under other laws.

Sunset clauses aren’t a silver bullet, but they do occasionally stop or slow things that would otherwise become permanent.