| ▲ | matt3210 10 hours ago | |||||||
Manually styling two similar things the same way is a code smell. Ask the ai to make common components and use them for both instead of brute forcing them to look similar. | ||||||||
| ▲ | PaulHoule 9 hours ago | parent [-] | |||||||
Yeah, I thought about this in that case. I tend to think the way you do to the extent that it is sometimes a source of conflict with other people I work with. These navbars are similar but not the same, both have a pager but they have other things, like one has some drop downs and the other has a text input. Styled "the same" means the line around the search box looks the same as the lines around the numbers in the pager, and Junie got that immediately. In the end the patch touched css classes in three lines of one file and added a css rule -- it had the caveat that one of the css classes involved will probably go away when the board finally agrees to make a visual change we've been talking about for most of a year but I left a comment in the first navbar warning about that. There are plenty of times I ask Junie to try to consolidate multiple components or classes into one and it does that too as directed. | ||||||||
| ||||||||