| ▲ | FieryMechanic 2 days ago | |
> The trick is to have warnings fail CI but not local builds Which is annoying because the CI pipeline can take like 10 minutes to do the build and then you need to re-commit after turning the warnings on locally. There are other issue like your code compiles differently in CI vs on your machine, which brings it own issues. Ignored warnings can cause other pieces to fail compilation or execution in other project/libraries. I had this happen in C# and VB.NET. It is best just to turn on all warnings and errors and be done with it. I've never heard particularly good reasons for not having it turned on all the time and that includes those mentioned in this thread. > Then erroring on unused variables will not help you anyway. The point I am trying to convey, which was a direct response to something the parent said: "barbarians who commit code that complies with warnings" IME it is very common for people to just straight up ignore warnings, and issues and sometimes they won't even check the thing compiles. I've worked as a contractor at a number of companies both large and small and this has been a constant. > Anyway, all your issues sound like management problems. Not all projects are run that badly. Again the point I was trying to convey is the expectations people have on here are far higher than what some of us have to deal with on a daily basis. So you have to put in loads of automated checks that I don't have to bother with when working with competent people. | ||