Remix.run Logo
throwaway150 6 hours ago

All of this makes sense. Thank you for explaining. I don't think I understand the difference though.

Like are they calling the "GitHub pull request" workflow as the push model? What is "push" about it though? I can download all the pull request patches to my local and work offline, can't I?

bayindirh 6 hours ago | parent [-]

GitHub pull request pushes you a notification/e-mail to handle the merge, and you have to handle the pull request mostly online.

I don't know how you can download the pull request as a set of patches and work offline, but you have to open a branch, merge the PR to that branch, test the things and merge that branch to relevant one.

Or you have to download the forked repository, do your tests to see the change is relevant/stable whatnot and if it works, you can then merge the PR.

---

edit: Looks like you can get the PR as a patch or diff, and is trivial, but you have to be online again to get it that way. So, getting your mails from your box is not enough, you have to get every PR as a diff, with a tool or manually. Then you have to organize them. e-mails are much more unified and simple way to handle all this.

---

In either case, reviewing the changes is not possible when you're offline, plus the pings of the PRs is distracting, if your project is popular.

lelandfe 6 hours ago | parent | next [-]

Seems like you found it, but for others: one of the easiest ways to get a PR's diff/patch is to just put .diff or .patch at the end of its URL. I use this all the time!

Random PR example, https://github.com/microsoft/vscode/pull/280106 has a diff at https://github.com/microsoft/vscode/pull/280106.diff

Another thing that surprises some is that GitHub's forks are actually just "magic" branches. I.e the commits on a fork exist in the original repo: https://github.com/microsoft/vscode/commit/8fc3d909ad0f90561...

compiler-guy 5 hours ago | parent [-]

It’s bonkers to me that there isn’t a link to the plan patch from the page. Yes, it’s trivial to add a suffix once you know, but lots of people don’t—as evidenced by this thread.

Discoverability in UX seems to have completely died.

bayindirh 4 hours ago | parent [-]

> It’s bonkers to me that there isn’t a link to the plan patch from the page.

It's yet another brick on the wall of the garden. That's left there for now, but for how long?

IOW, It's deliberate. Plus, GitHub omits to add trivial features (e.g.: deleting projects, "add review" button, etc.) while porting their UI.

It feels like they don't care anymore.

kijin 5 hours ago | parent | prev [-]

You could set up a script that lives in the cloud (so you don't have to), receives PRs through webhooks, fetches any associated diff, and stores them in S3 for you to download later.

Maybe another script to download them all at once, and apply each diff to its own own branch automatically.

Almost everything about git and github/gitlab/etc. can be scripted. You don't have to do anything on their website if you're willing to pipe some text around the old way.

bayindirh 4 hours ago | parent [-]

Why complicate the workflow when it can be solved with a simple e-mail?

> Almost everything about git and github/gitlab/etc. can be scripted.

Moving away from GitHub is more philosophical than technical at this point. I also left the site the day they took Copilot to production.