Success is relative. The Steam Deck is only unsuccessful if you consider the goal of the device to be "outsell Nintendo". I would argue 4 million units is not merely a success, but a massive success.

For an interesting comparison, the PS Vita did about 4 million in the first year.