| ▲ | TheDong 4 days ago | |||||||||||||||||||
You can't hide from the pickaxe
gets us the commit [0] from 2020 where config_inflateSignalStrength was renamed to KEY_INFLATE_SIGNAL_STRENGTH_BOOL
gets us this commit [1] from 2017 where it was originally added:
[0]: https://android.googlesource.com/platform//frameworks/base/+...[1]: https://android.googlesource.com/platform//frameworks/base/+... | ||||||||||||||||||||
| ▲ | lovelearning 4 days ago | parent | next [-] | |||||||||||||||||||
The 2017 commit has these code changes:
If the flag is true, bump up BOTH the reported level as well as the total number of bins.If the flag is false, use reported level and default number of bins. Since both numerator and denominator are bumped up, is it really malicious? Based on this commit at least, personally, I feel such logic could be due to a decision to shift from levels starting from 0 to levels starting from 1 at the UI level. Or perhaps to make levels consistent between different operators, some of whom were using 0-based while others used 1-based. I haven't gone through later commits or latest versions. So my opinion's limited just to this original 2017 change. | ||||||||||||||||||||
| ||||||||||||||||||||
| ▲ | userbinator 4 days ago | parent | prev | next [-] | |||||||||||||||||||
I'm surprised they even display the name and email of the person responsible for doing it. If I were forced to make such a change that I knew would be publicly displayed, I'd do everything possible to disclaim it (such as mentioning the one who actually requested it.) | ||||||||||||||||||||
| ||||||||||||||||||||
| ▲ | NooneAtAll3 4 days ago | parent | prev [-] | |||||||||||||||||||
I applaud your inventiveness (but I still would love to know how does one hide from git blame) (file renaming?) | ||||||||||||||||||||