▲ | rollulus 5 days ago | ||||||||||||||||||||||||||||||||||
I have received a few LLM produced PRs from peers from adjacent teams, in good faith but not familiar with the project, and they increasingly infuriate me. They were all garbage, but there’s a great asymmetry: it costs my peers nothing to generate them, it costs me precious time to refute them. And what can I do really? Saying “it’s irreparable garbage because the syntax might be right but it’s conceptually nonsense” but that’s not the most constructive take. | |||||||||||||||||||||||||||||||||||
▲ | esperent 5 days ago | parent | next [-] | ||||||||||||||||||||||||||||||||||
You could use an LLM to give you advice on how to present that take in a more constructive manner. Partially sarcastic but I do personally use LLMs to guide my communication in very limited cases: 1. It's purely business related, and 2. I'm feeling too emotionally invested (or more likely, royally pissed off) and don't trust myself to write in a professional manner, and 3. I genuinely want the message to sound cold, corporate, and unemotional Number 3 would fit you here. These people are not being respectful to you in presenting code for review that respects your time. Why should you take the time to write back personally? It should be noted that this accounts for maybe 5% of my business communications, and I'm careful not to let that number grow. | |||||||||||||||||||||||||||||||||||
| |||||||||||||||||||||||||||||||||||
▲ | sothatsit 5 days ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||
This feels like a culture problem. I have seen higher-quality PRs as people use AI to review their work before pushing it. This means less silly typos and obvious small bugs. | |||||||||||||||||||||||||||||||||||
▲ | bootsmann 5 days ago | parent | prev | next [-] | ||||||||||||||||||||||||||||||||||
Nothing makes me hate AI more than getting a slop PR written by one of the agent-wielding coworkers with the comments describing what the next line does for every line. More often than not it looks plausible but turns out to be completely unusable upon closer inspection. Incredibly disrespectful to do this to your coworkers imo, its proper that you call it out. | |||||||||||||||||||||||||||||||||||
▲ | tjpnz 5 days ago | parent | prev [-] | ||||||||||||||||||||||||||||||||||
If you had a colleague who was consistently writing complete shit you would raise it with your manager. This situation isn't all that different - the only complicating factor they're not on your team. If it's only happened a few times you might first try setting some ground rules for contributions. Really common for innersource repos to have a CONTRIBUTING.md file or similar. Add a checkbox to your PR template that the dev has to check to indicate they've read it, then wait and see. |