Remix.run Logo
Liriel 2 days ago

My pet peeve is people who use LLMs to generate code, never check whether it works, and then submit a PR.

As if open-source maintainers don't have enough chores.

rikroots 2 days ago | parent | next [-]

I await the first LLM generated PR to my JS canvas library with eager anticipation.

I can't wait to ask them if they've run the PR branch against all of the test demos, so they can prove that the PR doesn't break existing functionality. Currently there's just under 200 test demos, each of which needs to be tested manually (because: hell = canvas library + animation) across the three main browsers to make sure nothing breaks. Bonus points for going the extra mile for testing on mobile device browsers.

meesles 2 days ago | parent | prev | next [-]

Over the last 6 months this has been my experience with new engineers at work, absolutely awful. I wish people didn't feel the need to throw out SDLC once the LLMs came along.

palata 2 days ago | parent | prev [-]

It's not rare for me to ask if they tested it. They can lie, but if they say they did and it crashes on me right when I start it, then I may never trust this contributor ever again.

Also I don't hesitate to be frank in my review, it's okay to say "I won't merge your feature because I don't think I can maintain that, but you're free to keep your fork". Or "I can merge it if you change this and this", but in that case I need to actually merge if they do what I asked for.

latexr 2 days ago | parent [-]

> They can lie, but if they say they did and it crashes on me right when I start it, then I may never trust this contributor ever again.

If it’s obvious without a shadow of a doubt that someone has lied, either on an issue or a PR, I’m very much inclined to block them. I have a lot of patience for people who are still learning or make silly mistakes but are genuinely making an effort; but if someone doesn’t even help me help them, that’s disrespectful and such behaviour shouldn’t be rewarded.