I got a MR the other day that should be 40 lines of code but it was 1000. It "mostly" worked. Do I pick apart this slop? Why should I? It's bad for the team and for the project.

It's hard to respond to that. I'm genuinely stumped. As I explain in the post, this is me trying to write something re-usable to share with people who do that to a team lead.

▲

thekevan 2 days ago | parent [-]

"I got a MR the other day that should be 40 lines of code but it was 1000. It "mostly" worked."

I mean just stop there. It isn't a good MR.

	▲	zulban 2 days ago \| parent [-]
		I think you're missing the point. If I give a fun extreme example it doesn't mean there's no subtle problem. Where do you draw the line? Maybe I guessed 40 but it would really be 80. Maybe they send in 400 lines. 200? Also 1000 is maybe fine if it's a one shot script that just works one time on non-prod.