While cool it’s a bit of a cop out to use a bitmap as a mask for both the circular shape and the shading of the earth’s shadow.

▲

emptybits 2 days ago | parent | next [-]

I agree. And if you copy and paste the ASCII moon they have there, it does already have a perfectly good circular shape to it. Well done.

It's ASCII art. Drop the bitmap mask.

▲

ludicrousdispla 2 days ago | parent | prev | next [-]

Lunar phase should be showing the moon's shadow (on itself) which will not be circular from our perspective on Earth except during the new moon phase.

This looks more like what is seen during a solar eclipse.

	▲	eichin 2 days ago \| parent [-]
		Yeah, this rendering is Just Wrong - moon phase is viewing a half-lit sphere from different angles, no external shadows are involved. Maybe look at https://github.com/chubin/pyphoon instead, which claims a history including Jef Poskanzer code going back to the 1970s...

▲

way_stone 2 days ago | parent | prev | next [-]

If "live in ASCII art" is the pitch, it's reasonable to expect ASCII itself being the part that is "live".

	▲	_aavaa_ 2 days ago \| parent [-]
		But the vectors/bitmaps aren’t needed. The moon circle is already done in ascii. And the shading could at least be done with font color.

▲

mlindner 2 days ago | parent | prev [-]

The moon doesn't have the Earth's shadow on it though. So it's wrong in that respect too.