| ▲ | ack_complete a month ago | |||||||||||||
I'm surprised there's no mention of store forwarding in that discussion. The -O3 codegen is bonkers, but the -O2 output is reasonable. In the case where one of the structs has just been computed, attempting to load it as a single 32-bit load can result in a store forwarding failure that would negate the benefit of merging the loads. In a non-inlined, non-PGO scenario the compiler doesn't have enough information to tell whether the optimization is suitable. | ||||||||||||||
| ▲ | mshockwave a month ago | parent | next [-] | |||||||||||||
> In the case where one of the structs has just been computed, attempting to load it as a single 32-bit load can result in a store forwarding failure It actually depends on the uArch, Apple silicon doesn't seem to have this restriction: https://news.ycombinator.com/item?id=43888005 > In a non-inlined, non-PGO scenario the compiler doesn't have enough information to tell whether the optimization is suitable. I guess you're talking about stores and load across function boundaries? Trivia: X86 LLVM creates a whole Pass just to prevent this partial-store-to-load issue on Intel CPUs: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Targ... | ||||||||||||||
| ▲ | Dylan16807 a month ago | parent | prev [-] | |||||||||||||
> In the case where one of the structs has just been computed, attempting to load it as a single 32-bit load can result in a store forwarding failure that would negate the benefit of merging the loads Would that failure be significantly worse than separate loading? Just negating the optimization wouldn't be much reason against doing it. A single load is simpler and in the general case faster. | ||||||||||||||
| ||||||||||||||