▲ | foota 3 days ago | |
In isolation, sure writing code more expressively isn't a bad thing, and might be fine as an exercise for becoming more familiar with some part of the codebase, but I don't think it's a good use of time for the author or reviewers to go and do this without some other motivation or if you're touching the code already. | ||
▲ | bluGill 2 days ago | parent [-] | |
Getting someone new is itself motivation. And if the result is better code thateis a good use of time. often manual loops have unnoticed off by one errors as well so the above exercise can fix weird bugs nobody has figured out. |