I think the Ryobi are a good choice. ~12 years ago I got Porter Cable tools, and they worked very well for me over that time. But there was a pretty limited set of tools available, it did cover the core ones though. I had previously had DeWalt tools and felt I didn't use them up to their potential, so I went "down" to the Porter Cable.

I almost went with Ryobi when I did my recent refresh. But I've changed to doing way, way more with the tools, I'm basically using them every weekend now. And the Milwaukees are just a joy to use, though you do pay for that. One benefit I didn't realize when I bought the hammer drill: It will detect if it grabs and the tool starts spinning. I was using a mini auger to break up some soil and the Porter Cable I nearly broke my wrist when it grabbed. I got the Milwaukee partly because it had a second handle you could add, but the accelerometer worked even better than that.