> Wouldn't the right solution be to protect the citizens from all threats, foreign and domestic?

Maybe. But there is a huge constitutional distinction between foreign and domestic threats. And the supreme court was pretty clear that the decision would be different if it didn't reside with a "foreign adversary".