Elon Musk is not a scientist. He employs scientists.

But do general people know who is a scientist and who isn't? How do they find out?

It isn't by membership of a learned society, it isn't if they are working at a university. There is no simple way for a general person to know if somebody is a scientist.