| |
| ▲ | simiones 5 days ago | parent | next [-] | | In principle. In practice, most Go code, and even significant parts of the Go standard library, return arbitrary error strings. And error returning functions never return anything more specific than `error` (you could count the exceptions in the top 20 Go codebases on your fingers, most likely). Returning non-specific exceptions is virtually encouraged by the standard library (if you return an error struct, you run into major issues with the ubiquitous `if err != nil` "error handling" logic). You have both errors.New() and fmt.Errorf() for returning stringly-typed errors. errors.Is and errors.As only work easily if you return error constants, not error types (they can support error types, but then you have to do more work to manually implement Is() and As() in your custom error type) - so you can't easily both have a specific error, but also include extra information with that error. For the example in the OP, you have to do a lot of extra work to return an error that can be checked without string comparisons, but also tells you what was the actual limit. So much work that this was only introduced in Go 1.19, despite MaxBytesReader existing since go 1.0 . Before that, it simply returned errors.New("http: request body too large") [0]. And this is true throughout the standard library. Despite all of their talk about the importance of handling errors, Go's standard library was full of stringly-typed errors for most of its lifetime, and while it's getting better, it's still a common occurrence. And even when they were at least using sentinel errors, they rarely included any kind of machine-readable context you could use for taking a decision based on the error value. [0] https://cs.opensource.google/go/go/+/refs/tags/go1:src/pkg/n... | | |
| ▲ | kbolino 5 days ago | parent [-] | | You do not have to do more work to use errors.Is or errors.As. They work out of the box in most cases just fine. For example: package example
var ErrValue = errors.New("stringly")
type ErrType struct {
Code int
Message string
}
func (e ErrType) Error() string {
return fmt.Sprintf("%s (%d)", e.Message, e.Code)
}
You can now use errors.Is with a target of ErrValue and errors.As with a target of *ErrType. No extra methods are needed.However, you can't compare ErrValue to another errors.New("stringly") by design (under the hood, errors.New returns a pointer, and errors.Is uses simple equality). If you want pure value semantics, use your own type instead. There are Is and As interfaces that you can implement, but you rarely need to implement them. You can use the type system (subtyping, value vs. pointer method receivers) to control comparability in most cases instead. The only time to break out custom implementations of Is or As is when you want semantic equality to differ from ==, such as making two ErrType values match if just their Code fields match. The one special case that the average developer should be aware of is unwrapping the cause of custom errors. If you do your own error wrapping (which is itself rarely necessary, thanks to the %w specifier on fmt.Errorf), then you need to provide an Unwrap method (returning either an error or a slice of errors). | | |
| ▲ | simiones 4 days ago | parent | next [-] | | Your example is half right, I had misread the documentation of errors.As [0]. errors.As does work as you describe, but errors.Is doesn't: that only compares the error argument for equality, unless it implements Is() itself to do something different. So `var e error ErrType{Code: 1, Message: "Good"} = errors.Is(e, ErrType{})` will return false. But indeed Errors.As will work for this case and allow you to check if an error is an instance of ErrType. [0] https://play.golang.com/p/qXj3SMiBE2K | | |
| ▲ | kbolino 3 days ago | parent [-] | | As I said, errors.Is works with ErrValue and errors.As works with ErrType. I guess the word "Is" is doing too much work here, because I wouldn't expect ErrType{Code:1} and ErrType{Code:0} to match under errors.Is, though ErrType{Code:1} and ErrType{Code:1} would, but yes you could implement an Is method to override that default behavior. |
| |
| ▲ | dgunay 4 days ago | parent | prev | next [-] | | If you want errors to behave more like value types, you can also implement `Is`. For example, you could have your `ErrType`'s `Is` implementation return true if the other error `As` an `ErrType` also has the same code. | | |
| ▲ | kbolino 3 days ago | parent [-] | | If you have a value type, you don't need to implement Is. It's just that errors.New (and fmt.Errorf) doesn't return a value type, so such errors only match under errors.Is if they have the same identity, hence why you typically see them defined with package-level sentinel variables. |
| |
| ▲ | kbolino 4 days ago | parent | prev [-] | | Probably worth noting that errors.As uses assignability to match errors, while errors.Is is what uses simple equality. Either way, both work well without custom implementations in the usual cases. |
|
| |
| ▲ | unscaled 5 days ago | parent | prev | next [-] | | Go errors cannot be string-typed, since they need to implement the error interface. The reason testing error types sometimes won't work is that the error types themselves may be private to the package where they are defined or that the error is just a generic error created by errors.New(). In this case the Error has an easy-to-check public type (*MaxBytesError) and the documentation clearly indicates that. But that has not always been the case. The original sin is that the API returned a generic error and the only way to test that error was to use a string comparison. This is an important context to have when you need to make balanced decisions about Hyrum's law. As some commentators already mentioned, you should be wary of taking the extreme version of the law, which suggest that every single observable behavior of the API becomes part of the API itself and needs to be preserved. If you follow this extreme version, every error or exception message in every language must be left be left unchanged forever. But most client code doesn't just go around happily comparing exception messages to strings if there is another method to detect the exception. | |
| ▲ | karel-3d 4 days ago | parent | prev | next [-] | | They didn't have them when they implemented this code. Back then, error was a glorified string. Then it started having more smart errors, mostly due to a popular third party packages, and then the logic of those popular packages was more or less* put back to go. * except for stacktraces in native errors. I understand that they are not there for speed reasons but dang it would be nice to have them sometimes | |
| ▲ | adontz 5 days ago | parent | prev | next [-] | | Nobody teaches people to use them. There is no analog to "catch most specific exceptions" culture in other languages. | |
| ▲ | TheDong 5 days ago | parent | prev | next [-] | | It has typed errors, except every function that returns an error returns the 'error' interface, which gives you no information on the set of errors you might have. In other statically typed languages, you can do things like 'match err' and have the compiler tell you if you handled all the variants. In java you can `try { x } catch (SomeTypedException)` and have the compiler tell you if you missed any checked exceptions. In go, you have to read the recursive call stack of the entire function you called to know if a certain error type is returned. Can 'pgx.Connect' return an `io.EOF` error? Can it return a "tls: unknown certificate authority" (unexported string only error)? The only way to know is to recursively read every line of code `pgx.Connect` calls and take note of every returned error. In other languages, it's part of the type-signature. Go doesn't have _useful_ typed errors since idiomatically they're type-erased into 'error' the second they're returned up from any method. | | |
| ▲ | inlined 4 days ago | parent | next [-] | | You actually should never return a specific error pointer because you can eventually break nil checks. I caused a production outage because interfaces are tuples of type and pointer and the literal nil turns to [nil, nil] when getting passed to a comparator whereas your struct return value will be [nil, *Type] | | |
| ▲ | stouset 4 days ago | parent [-] | | It's really hard to reconcile behavior like this with people's seemingly unshakeable love for golang's error handling. | | |
| |
| ▲ | rocqua 5 days ago | parent | prev [-] | | Exceptions in Python and C are the same. The idea with these is, either you know exactly what error to expect to handle and recover it, or you just treat it as a general error and retry, drop the result, propagate the error up, or log and abort. None of those require understanding the error. Should an unexpected error propagate from deep down in your call stack to your current call site, do you really think that error should be handled at this specific call-site? | | |
| |
| ▲ | Svip 5 days ago | parent | prev | next [-] | | The consumer didn't, but the error in the example is typed, it's called `MaxBytesError`. | | |
| ▲ | eptcyka 5 days ago | parent | next [-] | | Matching the underlying type when using an interface never feels natural and is definitely the more foreign part of Go's syntax to people who are not super proficient with it. Thus, they fall back on what they know - string comparison. | |
| ▲ | simiones 5 days ago | parent | prev [-] | | Only since go 1.19. It was a stringy error since go 1.0 until then. |
| |
| ▲ | stouset 4 days ago | parent | prev [-] | | Go didn't have them at the time. Pessimistically this is yet another example of the language's authors relearning why other languages have the features they do one problem at a time. |
|
